CI: bump GHC to recommended version (9.4.7) #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me -> merging. |
|
I looks a lot like this commit pushed the checking time for the library up from around 35min to 50min. Is there a reason for that? |
|
Might be just noise in the github-builttimes... |
|
Looking at recent runs, I see build times between 3 and 110 minutes: https://github.com/agda/cubical/actions?query=branch%3Amaster+event%3Apush A priori, I do not see a reason why bumping the GHC version would cause a regression in Agda type-checking times, but of course there could be a GHC regression... One would need some reproducer... |
|
Thanks for the input - I guess I should do some profiling locally, when I have some time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.